-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove WriteHandler::Abort. #24880
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-write-handler-abort
Feb 8, 2023
Merged
Remove WriteHandler::Abort. #24880
yufengwangca
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-write-handler-abort
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's basically just Close, except missing some state updates, and not doing the "is this actually in use" check that Close does. We can guard on that check in the caller and call Close. Fixes project-chip#21740
PR #24880: Size comparison from 3d09d2d to 3d6dd5e Increases (6 builds for cc13x2_26x2)
Decreases (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Feb 6, 2023
yunhanw-google
approved these changes
Feb 6, 2023
jmartinez-silabs
approved these changes
Feb 8, 2023
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Feb 13, 2023
It's basically just Close, except missing some state updates, and not doing the "is this actually in use" check that Close does. We can guard on that check in the caller and call Close. Fixes project-chip#21740
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
It's basically just Close, except missing some state updates, and not doing the "is this actually in use" check that Close does. We can guard on that check in the caller and call Close. Fixes project-chip#21740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's basically just Close, except missing some state updates, and not doing the "is this actually in use" check that Close does. We can guard on that check in the caller and call Close.
Fixes #21740